TFM bounds checks for safety#10964
Open
SparkiDev wants to merge 1 commit into
Open
Conversation
fp_to_unsigned_bin_len did not deal with negative input length - fails early now. No code in wolfSSL calls mp_to_unsigned_bin_len with a negative len. fp_is_bit_set and fp_set_bit check for greater than or equal to FP_MAX_BITS instead of just greater. Check doesn't cause issues as FP_MAX_SIZE has padding but it was the wrong check.
Contributor
Author
|
Jenkins: retest this please Visual Studio: remote connection dropped |
wolfSSL-Fenrir-bot
left a comment
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #10964
Scan targets checked: wolfcrypt-bugs, wolfcrypt-src
No new issues found in the changed files. ✅
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
fp_to_unsigned_bin_len did not deal with negative input length - fails early now. No code in wolfSSL calls mp_to_unsigned_bin_len with a negative len.
fp_is_bit_set and fp_set_bit check for greater than or equal to FP_MAX_BITS instead of just greater. Check doesn't cause issues as FP_MAX_SIZE has padding but it was the wrong check.
Testing
Tested with --enable-fastmath.